Skip to content

electron osx builds#1041

Merged
kewde merged 2 commits intoTryGhost:masterfrom
kewde:patch-3
Oct 17, 2018
Merged

electron osx builds#1041
kewde merged 2 commits intoTryGhost:masterfrom
kewde:patch-3

Conversation

@kewde
Copy link
Copy Markdown
Collaborator

@kewde kewde commented Sep 18, 2018

No description provided.

@kewde
Copy link
Copy Markdown
Collaborator Author

kewde commented Sep 18, 2018

Bins are building fine, the test suite isn't running because the Travis-CI environment is headless.
I'm hoping to resolve it.

@kewde
Copy link
Copy Markdown
Collaborator Author

kewde commented Sep 18, 2018

@springmeyer

Issue has been resolved.
There are no OSX builds being uploaded. Can you please merge & publish a build and give me a ping?
I'll verify that they are being uploaded correctly.

@kewde
Copy link
Copy Markdown
Collaborator Author

kewde commented Sep 18, 2018

Please restart the following job, test all pass, seems like an issue with homebrew:
https://travis-ci.org/mapbox/node-sqlite3/jobs/430224908

@ghost
Copy link
Copy Markdown

ghost commented Sep 20, 2018

@springmeyer Would it be possible to get this change into master so it publishes the binaries correctly to S3?

Thanks again for the quick fix @kewde

@springmeyer
Copy link
Copy Markdown
Contributor

@kewde I'm unable to do this work since I've switched roles at Mapbox. However I've added you as a contributor if you can merge and run out the release yourself. /cc @mapsam

@kewde
Copy link
Copy Markdown
Collaborator Author

kewde commented Sep 26, 2018

I've accepted the invitation, I'll wait for @mapsam for further input.
Is there a point of contact if I run into obstacles?

@mapsam
Copy link
Copy Markdown
Contributor

mapsam commented Oct 1, 2018

@kewde @springmeyer thanks for the ping - this looks good to me 👍 taking a look at the failing job right now

@mapsam
Copy link
Copy Markdown
Contributor

mapsam commented Oct 1, 2018

Ah, looks like this failure isn't related and is happening in other branches. @kewde feel free to merge and publish binaries for electron/osx. Do you think it would suffice to republish on the current version 4.0.2? Otherwise I'd be happy with a 4.1.0 release if that makes sense to you.

@kewde
Copy link
Copy Markdown
Collaborator Author

kewde commented Oct 6, 2018

It would suffice I suppose. What the release procedure? Is it just as simple as adding the publish command in the latest commit? @mapsam @springmeyer

@springmeyer
Copy link
Copy Markdown
Contributor

@mapsam
Copy link
Copy Markdown
Contributor

mapsam commented Oct 8, 2018

Release procedure is documented in the CONTRIBUTING.md here https://github.com/mapbox/node-sqlite3/blob/master/CONTRIBUTING.md#releasing

Not sure if you've been added to the NPM org - if not I can hit that final button when ready, just let me know. Once this branch is merged, you can make the release commit directly on master with the [publish binary] string added to the end of the commit message. Here's an example release commit from @springmeyer 93c9ecc

@springmeyer any quick ideas on why https://travis-ci.org/mapbox/node-sqlite3/jobs/430224893 is failing?

@kewde kewde merged commit 830275e into TryGhost:master Oct 17, 2018
@kewde kewde deleted the patch-3 branch October 17, 2018 10:38
@kewde
Copy link
Copy Markdown
Collaborator Author

kewde commented Oct 17, 2018

@mapsam @springmeyer

Could someone make a npm package release for 4.0.3, I've merged all electron changes.
Alternatively, add me as a collaborator there.

@mapsam
Copy link
Copy Markdown
Contributor

mapsam commented Oct 22, 2018

@kewde just got set up on npm myself for sqlite3 - 4.0.3 has been published! Thanks so much.

@ghost
Copy link
Copy Markdown

ghost commented Oct 23, 2018

Just downloaded the pre-built OSX package for Electron! Appreciate all the effort folks 👍

@kewde
Copy link
Copy Markdown
Collaborator Author

kewde commented Oct 25, 2018

@nocodaio please let me know if there are any issues, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants